Magento 2.2 Fix Notice and Exception while adding image to product programmatically#19238
Closed
gelanivishal wants to merge 5 commits intomagento:2.2-developfrom
Closed
Magento 2.2 Fix Notice and Exception while adding image to product programmatically#19238gelanivishal wants to merge 5 commits intomagento:2.2-developfrom
gelanivishal wants to merge 5 commits intomagento:2.2-developfrom
Conversation
…to product programmatically magento#18952 - Fixed docblocks
Contributor
|
Hi @gelanivishal. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
|
Closing as we already have #18951 created by original PR author. @gelanivishal thanks for collaboration! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR
#18952
Fixed Issues (if relevant)
Preconditions
Magento Version 2.3
PHP Version 7.2
Steps to reproduce
Expected result
Image gets added
Actual result
Exception gets thrown:
There's a workaround for this issue, using the
Product::savemethod instead of theProductRepositoryInterface::savemethod, but because it's a deprecated method I would like to avoid this.Contribution checklist