Magento 2.3 Fix Notice and Exception while adding image to product programmatically

[progreg]

Fixed Issues (if relevant)

1. Product::addImageToMediaGallery throws Exception #6803: Product::addImageToMediaGallery throws Exception

Preconditions

Magento Version 2.3
PHP Version 7.2

Steps to reproduce

$product = $this->productFactory->create()
            ->setName($productName)
            ->setStatus($productStatus)
            ->setSku($productSku)
$product->setAttributeSetId($product->getDefaultAttributeSetId());

$product->addImageToMediaGallery($file, [
                'image',
                'small_image',
                'thumbnail',
            ], false, false);
$this->productRepository->save($product);

Expected result

Image gets added

Actual result

Exception gets thrown:

Notice: Undefined index: media_type in vendor/magento/module-catalog/Model/Product.php on line 2527

There's a workaround for this issue, using the Product::save method instead of the ProductRepositoryInterface::save method, but because it's a deprecated method I would like to avoid this.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @progreg. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[progreg]

@orlangur , @slavvka please check if all change requests were implemented in a proper way from my side. Thanks

[slavvka]

@orlangur , @slavvka please check if all change requests were implemented in a proper way from my side. Thanks

@progreg looks good. Please add an integration test to have this scenario checked automatically since this could be tested only programmatically.

[progreg]

@slavvka, done

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-3421 has been created to process this Pull Request

[magento-engcom-team]

Hi @progreg. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.