Skip to content

[UI] Fix selection of all items which are not visible in ui grid #19204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 2 commits into from
Nov 22, 2018
Merged

[UI] Fix selection of all items which are not visible in ui grid #19204

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a8763
Fix selection of all items which are not visible in ui grid
progreg Nov 14, 2018
e90bc28
Fix static analysis errors
progreg Nov 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/code/Magento/Ui/view/base/web/js/grid/massactions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ define([
var itemsType = data.excludeMode ? 'excluded' : 'selected',
selections = {};

if (itemsType === 'excluded' && data['selected'].length){
data['selected'] = _.difference(data['selected'], data['excluded']);
itemsType = 'selected';
}

selections[itemsType] = data[itemsType];

if (!selections[itemsType].length) {
Expand Down