Skip to content

[UI] Fix selection of all items which are not visible in ui grid#19204

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
progreg:2.3-develop-18983-issue
Nov 22, 2018
Merged

[UI] Fix selection of all items which are not visible in ui grid#19204
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
progreg:2.3-develop-18983-issue

Conversation

@progreg
Copy link
Copy Markdown
Contributor

@progreg progreg commented Nov 14, 2018

Description (*)

When you using select all option in UI grid, massaction js component sends only exclude list to server and Data Provider don't know what scope of ids should be selected from DB. In case if we will select some orders to be canceled and meanwhile some customer will place a new one, this new one order will be canceled too. This issue was fixed.

Fixed Issues

  1. Select all orders selecting orders which are not visible in order grid.  #18983: Select all orders selecting orders which are not visible in order grid

Manual testing scenarios (*)

  1. Go to order grid
  2. Select all orders on that page
  3. Place an order
  4. Without refreshing page move all orders to hold or any other status
  5. Check updated order status for new order

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @progreg. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@progreg
Copy link
Copy Markdown
Contributor Author

progreg commented Nov 14, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @progreg. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @progreg, here is your Magento instance.
Admin access: http://34.228.235.121/i-19204-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@progreg progreg added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 14, 2018
@VladimirZaets VladimirZaets self-assigned this Nov 14, 2018
@VladimirZaets VladimirZaets removed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 14, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 14, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3463 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @progreg. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants