Skip to content

[Backport] Removed commented code#18432

Merged
magento-engcom-team merged 3 commits intomagento:2.2-developfrom
lewisvoncken:2.2-develop-PR-port-17346
Oct 8, 2018
Merged

[Backport] Removed commented code#18432
magento-engcom-team merged 3 commits intomagento:2.2-developfrom
lewisvoncken:2.2-develop-PR-port-17346

Conversation

@lewisvoncken
Copy link
Copy Markdown
Contributor

Original Pull Request

#17346

Description

Removed commented code and make it cleaner more.

Fixed Issues (if relevant)

  1. Removed commented code #17316: Removed commented code

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @lewisvoncken. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

1 similar comment
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @lewisvoncken. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants