Skip to content

Removed commented code#17316

Closed
mage2pratik wants to merge 1 commit intomagento:2.1-developfrom
mage2pratik:remove-commented-code-5
Closed

Removed commented code#17316
mage2pratik wants to merge 1 commit intomagento:2.1-developfrom
mage2pratik:remove-commented-code-5

Conversation

@mage2pratik
Copy link
Copy Markdown
Contributor

@mage2pratik mage2pratik commented Aug 1, 2018

Description

Removed commented code and make it cleaner more.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Aug 1, 2018 •
edited
Loading

Hi @mage2pratik,
According to new rules we're not accepting code cleanup pull requests for 2.1 release line anymore.
More details: https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#rules

I'm closing this PR

@ihor-sviziev ihor-sviziev self-assigned this Aug 1, 2018
@mage2pratik mage2pratik mentioned this pull request Aug 3, 2018
Merged
4 tasks
@lewisvoncken lewisvoncken mentioned this pull request Oct 6, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ihor-sviziev ihor-sviziev

Labels

Cleanup Component: Framework/ObjectManager Component: Review Release Line: 2.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mage2pratik @ihor-sviziev @magento-engcom-team