Skip to content

[Forwardport] Fixes black background for png images in wysiwyg editors.#17834

Closed
nmalevanec wants to merge 1 commit into
magento:2.3-developfrom
nmalevanec:2.3-develop-PR-port-16733
Closed

[Forwardport] Fixes black background for png images in wysiwyg editors.#17834
nmalevanec wants to merge 1 commit into
magento:2.3-developfrom
nmalevanec:2.3-develop-PR-port-16733

Conversation

@nmalevanec
Copy link
Copy Markdown
Contributor

Original Pull Request

#16733

Description

This PR fixes the black background for png images, which are uploaded in wysiwyg editors. This issue appears only for GD2 image processing library.

Fixed Issues (if relevant)

  1. Transparent background becomes black for thumbnails of PNG into Wysiwyg editor... #14248: Transparent background becomes black for thumbnails of PNG into Wysiwyg editor

Manual testing scenarios

  1. Upload a png image from any wysiwyg editor
  2. The background while previewing of this image should be transparent.
    61eb1dd578

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda
Copy link
Copy Markdown
Contributor

We'll go with #17855, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants