Skip to content

Resolved : Wishlist icon cut on Shopping cart page in mobile view #17851 #17852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hitesh-wagento wants to merge 6 commits into from
Closed

Resolved : Wishlist icon cut on Shopping cart page in mobile view #17851 #17852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7180790
PR#7903 correct the position of the datepicker when you scroll
lionelalvarez Nov 5, 2017
50d68e9
Merge pull request #23 from hitesh-wagento/2.2-develop-PR-port-12045
hitesh-wagento Jul 13, 2018
67f678f
Merge branch '2.2-develop' of github.com:hitesh-wagento/magento2 into…
hitesh-wagento Aug 29, 2018
fb3a790
Merge remote-tracking branch 'upstream/2.2-develop' into 2.2-develop
hitesh-wagento Aug 29, 2018
913d679
Merge remote-tracking branch 'upstream/2.2-develop' into 2.2-develop
hitesh-wagento Aug 31, 2018
ee67419
[Resolved: Wishlist icon cut on Shopping cart page in mobile view #17…
hitesh-wagento Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/design/adminhtml/Magento/backend/web/css/source/forms/fields/_control-table.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@
}
}

td {
.admin__field-control {
Copy link
Copy Markdown
Member

@osrecio osrecio Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this class should be added?

Copy link
Copy Markdown
Contributor Author

@hitesh-wagento hitesh-wagento Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @osrecio

I have changed only one file : a34ab10

Copy link
Copy Markdown
Member

@osrecio osrecio Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update your branch with last changes because I'm viewing 2 files modified in this PR : https://github.com/magento/magento2/pull/17852/files

Copy link
Copy Markdown
Contributor Author

@hitesh-wagento hitesh-wagento Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Means do you want I will remove that change from my branch?

Copy link
Copy Markdown
Member

@osrecio osrecio Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update your branch 2.2-develop with lasts changes and rebase with your branch and push.

Copy link
Copy Markdown
Contributor Author

@hitesh-wagento hitesh-wagento Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share with me steps. How can I rebase

Copy link
Copy Markdown
Member

@osrecio osrecio Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this video: https://www.youtube.com/watch?v=mJDCL0uzIpY&list=PLDvMskiz68Q3lLDOe2pMXssh8iVTinRN7&index=1

Copy link
Copy Markdown
Contributor Author

@hitesh-wagento hitesh-wagento Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commit and push changes can you please check once again.

Copy link
Copy Markdown
Member

@osrecio osrecio Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent you a ping via EngCom Slack. We can continue by this way.

position: relative;
}
}

th {
color: @color-very-dark-gray-black;
font-size: @font-size__base;
Expand Down
3 changes: 3 additions & 0 deletions app/design/frontend/Magento/luma/Magento_Wishlist/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,9 @@
@_icon-font-color-hover: @primary__color,
@_icon-font-color-active: @minicart-icons-color
);
&:before {
overflow: visible;
}
}
}
}
Expand Down