Resolved : Wishlist icon cut on Shopping cart page in mobile view #17851

[hitesh-wagento]

Summary

Wishlist icon cut on Shopping cart page in mobile view.

Issue : #17851

Preconditions

1. Magento 2x - This issue reproduce in all version.

Steps to reproduce

1. Login in your frontend.
2. Add any product in Cart.
3. Go to Shopping cart.
4. Switch mobile view.

Expected result

1. Wishlist icon should not cut in mobile view.
   

Actual result

1. Wishlist icon cut in mobile view.

[magento-engcom-team]

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[osrecio]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @osrecio. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @osrecio, here is your new Magento instance.
Admin access: https://pr-17852.engcom.dev.magento.com/admin
Login: admin Password: 123123q

[osrecio]

Hi @hitesh-wagento I can't reproduce this error or solution in Test Instance.

I created a product test: https://pr-17852.engcom.dev.magento.com/test.html I followed the steps and I don't see the "heart" icon in the cart: https://pr-17852.engcom.dev.magento.com/checkout/cart/

Can you specify more the details or maybe I missing something?

[hitesh-wagento]

Hi @osrecio

Please create account and login thenafter you can see heart (wishlist) icon in cart page.

Thanks

[osrecio]

Hi @hitesh-wagento , yes you're right. Sorry.

I can reproduce the issue and your PR is OK.

Can you squash your commits in only 1.

Pull request should have a meaningful description of its purpose

[osrecio]

Why this class should be added?

[hitesh-wagento]

Hi @osrecio

I have changed only one file : a34ab10

[osrecio]

Can you update your branch with last changes because I'm viewing 2 files modified in this PR : https://github.com/magento/magento2/pull/17852/files

[hitesh-wagento]

Means do you want I will remove that change from my branch?

[osrecio]

Update your branch 2.2-develop with lasts changes and rebase with your branch and push.

[hitesh-wagento]

Can you please share with me steps. How can I rebase

[osrecio]

Check this video: https://www.youtube.com/watch?v=mJDCL0uzIpY&list=PLDvMskiz68Q3lLDOe2pMXssh8iVTinRN7&index=1

[hitesh-wagento]

I have commit and push changes can you please check once again.

[osrecio]

I sent you a ping via EngCom Slack. We can continue by this way.

[hitesh-wagento]

Created new PR #17877