[Backport] GoogleAnalytics: Added unit test for order success observer#17471
Closed
mage2pratik wants to merge 7 commits intomagento:2.1-developfrom
mage2pratik:2.1-develop-PR-port-17137
Closed
[Backport] GoogleAnalytics: Added unit test for order success observer#17471mage2pratik wants to merge 7 commits intomagento:2.1-developfrom mage2pratik:2.1-develop-PR-port-17137
mage2pratik wants to merge 7 commits intomagento:2.1-developfrom
mage2pratik:2.1-develop-PR-port-17137
Conversation
orlangur
approved these changes
Aug 9, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
Contributor
|
@magento-engcom-team combine 17473 17474 |
Contributor
|
Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you |
This was referenced Aug 9, 2018
Contributor
|
@mage2pratik all pull requests have been successfully combined together:
|
Contributor
|
Hi @mage2pratik , please, adapt tests to usage with corresponded PHPUnit version. |
Contributor
|
Hi @mage2pratik , I am closing this PR now due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17137
Description
This PR adds missing unit test for
Magento\GoogleAnalytics\Observer\SetGoogleAnalyticsOnOrderSuccessPageViewObserverclassFixed Issues (if relevant)
N/A
Manual testing scenarios
N/A