Skip to content

GoogleAnalytics: Added unit test for order success observer#17137

Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
rogyar:2.2-order-success-ga-ut
Jul 27, 2018
Merged

GoogleAnalytics: Added unit test for order success observer#17137
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
rogyar:2.2-order-success-ga-ut

Conversation

@rogyar
Copy link
Copy Markdown
Contributor

@rogyar rogyar commented Jul 25, 2018

Description

This PR adds missing unit test for Magento\GoogleAnalytics\Observer\SetGoogleAnalyticsOnOrderSuccessPageViewObserver class

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: GoogleAnalytics labels Jul 25, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rogyar. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

1 similar comment
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rogyar. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: GoogleAnalytics Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants