Skip to content

Correct return type of methods #16988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 2 commits into from
Jul 27, 2018
Merged

Correct return type of methods #16988

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26add9d
Correct return type of methods
mage2pratik Jul 21, 2018
45b3978
Correct return type of methods
mage2pratik Jul 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/Controller/Category/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public function __construct(
/**
* Initialize requested category object
*
* @return \Magento\Catalog\Model\Category
* @return \Magento\Catalog\Model\Category|bool
*/
protected function _initCategory()
{
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/CatalogSearch/Model/ResourceModel/EngineInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function processAttributeValue($attribute, $value);
*
* @param array $index
* @param string $separator
* @return string
* @return array

@orlangur orlangur Jul 21, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PHPDocs of all implementations as well.

*/
public function prepareEntityIndex($index, $separator = ' ');
}