Correct return type of methods#16988
Correct return type of methods#16988magento-engcom-team merged 2 commits intomagento:2.2-developfrom mage2pratik:fix-return-type
Conversation
|
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
| * @param array $index | ||
| * @param string $separator | ||
| * @return string | ||
| * @return array |
There was a problem hiding this comment.
Fix PHPDocs of all implementations as well.
orlangur
left a comment
There was a problem hiding this comment.
Sorry, I meant https://github.com/magento/magento2/blame/2.2-develop/app/code/Magento/CatalogSearch/Model/ResourceModel/Engine.php#L123 and it is already fixed. Should pull changes for 2.2-develop more frequently to my local.
|
Hi @orlangur, thank you for the review. |
|
Hi @mage2pratik. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Correct return type of methods.
Fixed Issues (if relevant)
Manual testing scenarios
N/A
Contribution checklist