Skip to content

[Backport] Use correct error message for duplicate error key in product import#16390

Closed
gelanivishal wants to merge 2 commits intomagento:2.1-developfrom
gelanivishal:2.1-develop-PR-port-15980
Closed

[Backport] Use correct error message for duplicate error key in product import#16390
gelanivishal wants to merge 2 commits intomagento:2.1-developfrom
gelanivishal:2.1-develop-PR-port-15980

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented Jun 25, 2018

Original Pull Request

#15980

Description

During product CSV import, when a Url key duplicate is detected after the validation phase, the error message display only the error template but not the actual error details.
I have changed the addRowError() call using the detailed error message.

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Relates to

#15980

@sidolov
Copy link
Copy Markdown
Contributor

sidolov commented Jul 3, 2018

Hi @gelanivishal , this pull request does not fix the bug, the case still reproducing. The error message for the duplicated key during the import does not contain any placeholders for the paramaeters.

@sidolov
Copy link
Copy Markdown
Contributor

sidolov commented Jul 19, 2018

@gelanivishal , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants