[Forwardport2.3] Fix incorrect type hinting in PHPDocs#16371
Closed
chirag-wagento wants to merge 1 commit intomagento:2.3-developfrom
chirag-wagento:forwordport23-incorrect-type-hinting
Closed
[Forwardport2.3] Fix incorrect type hinting in PHPDocs#16371chirag-wagento wants to merge 1 commit intomagento:2.3-developfrom chirag-wagento:forwordport23-incorrect-type-hinting
chirag-wagento wants to merge 1 commit intomagento:2.3-developfrom
chirag-wagento:forwordport23-incorrect-type-hinting
Conversation
Contributor
|
Hi @chirag-wagento. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
Author
|
As per this tickets comment #16122 (comment) created new pull request. |
Contributor
|
Hi @chirag-wagento, when porting pull requests author of the original commit must be preserved: ab64a2c Please cherry-pick this commit into your branch instead of doing a new commit from scratch and force push into the same branch. |
Contributor
|
Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15619
Description
Incorrect PHPdoc causes warnings in IDE.
Changes applied:
Fixed Issues
Manual testing scenarios
Contribution checklist