[Forwordport2.3] Fix incorrect type hinting in PHPDocs#16122
Closed
chirag-wagento wants to merge 45 commits intomagento:2.3-developfrom
chirag-wagento:forwordport2.3-incorrect-type-hinting
Closed
[Forwordport2.3] Fix incorrect type hinting in PHPDocs#16122chirag-wagento wants to merge 45 commits intomagento:2.3-developfrom chirag-wagento:forwordport2.3-incorrect-type-hinting
chirag-wagento wants to merge 45 commits intomagento:2.3-developfrom
chirag-wagento:forwordport2.3-incorrect-type-hinting
Conversation
[Forwardport] Removed unnecessary css.
[Forwardport] Make necessary space.
[Forwardport] Removed unused class from forms less file.
…or new products when using index on save
[Forwardport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s…
[Forwardport] Format the javascript code
[Forwardport] Fixed set template syntax issue
[Forwardport] Solve overlapping Issue on every Home page & category page of Hot Sel…
removed extraneous margin and compensated padding and set both to 0, which creates the same effect
[Forwardport] #15308 removed extraneous margin
[Forwardport] Removed unnecessary menu item called Magento_Catalog::inventory in Magento_Catalog.
[Forwardport] #13354 - [Improvement] Add HTML attributes to containers
[Forwardport] Small refactoring to better code readability
[Forwardport] fix for dropdown toggle icon in cart
[Forwardport] Correct return type of methods and typo correction.
[Forwardport] Extend default config instead overwrite
Contributor
|
Hi @chirag-wagento. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Member
|
Closing this PR. Check your trace of commits and create new PR. |
Contributor
Author
|
Hello @osrecio Sorry not getting you can you please explain me in brief. Thanks |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15619
Description
Incorrect PHPdoc causes warnings in IDE.
Changes applied:
Fixed Issues
Manual testing scenarios
Contribution checklist