Improve retrieval of first array element#16053
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom Jun 14, 2018
thomas-kl1:refactor/magento-rule
Merged
Improve retrieval of first array element#16053magento-engcom-team merged 1 commit intomagento:2.2-developfrom thomas-kl1:refactor/magento-rule
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
thomas-kl1:refactor/magento-rule
Conversation
okorshenko
approved these changes
Jun 12, 2018
Contributor
okorshenko
left a comment
okorshenko
left a comment
There was a problem hiding this comment.
thank you for code cleanup
Contributor
|
Hi @okorshenko, thank you for the review. |
Contributor
|
Hi @thomas-blackbird. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work has started in #14609
Description
Fix the way to retrieve the first item of an array, with
resetandkeyfunctions.