Code cleanup, add more visibility#14609
Merged
magento-engcom-team merged 3 commits intomagento:2.2-developfrom Apr 28, 2018
thomas-kl1:rule-abstract-condition-cleanup
Merged
Code cleanup, add more visibility#14609magento-engcom-team merged 3 commits intomagento:2.2-developfrom thomas-kl1:rule-abstract-condition-cleanup
magento-engcom-team merged 3 commits intomagento:2.2-developfrom
thomas-kl1:rule-abstract-condition-cleanup
Conversation
Member
Author
|
Hi @orlangur , any news ? |
Contributor
|
Hi @thomas-blackbird We took this PR in progress. PR will be merged in the nearest time. |
Contributor
|
@thomas-blackbird thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
magento-team
pushed a commit
that referenced
this pull request
Apr 28, 2018
Contributor
|
Hi @thomas-blackbird. Thank you for your contribution. |
This was referenced May 8, 2018
This was referenced Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See previsous PR: pull/14607
@orlangur I've applied your suggestions in this new PR.
Description
I was reading some piece of code when I see te "foreach" and "break" statements. I know that the "break" should be avoided, so here my suggestion to retrieve the key of the first element of the array.
Is there a goal to do it via a foreach and break?
I've fixed also some useless "else" statements and add some ternary operators to replace the conditions where there's only a value assignment.