Skip to content

Complete the fix for cache issue due to the currencies with no symbol#15902

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
dmytro-ch:fix/2.2-cache-issue-for-currencies-with-no-symbol
Jun 14, 2018
Merged

Complete the fix for cache issue due to the currencies with no symbol#15902
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
dmytro-ch:fix/2.2-cache-issue-for-currencies-with-no-symbol

Conversation

@dmytro-ch
Copy link
Copy Markdown
Contributor

Description

Using getCurrencySymbol() leads to a bug for currencies where there is no currency symbol - cache ends up being non-unique. Using currency code for caching is a more foolproof way.

The issue has been partially fixed in 2.2-develop branch in #13894 (Magento\ConfigurableProduct\Block\Product\View\Type\Configurable)
and #14559 (Magento\CatalogWidget\Block\Product\ProductsList).

Manual testing scenarios

  1. Test the Catalog Category View page (including configurable products)
  2. Test the Catalog Product List widget

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…he cache issue for currencies with no symbol
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 12, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1953 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Award: test coverage Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants