Fix cache issue for currencies with no symbol#13894
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom Mar 16, 2018
Merged
Fix cache issue for currencies with no symbol#13894magento-engcom-team merged 1 commit intomagento:2.2-developfrom
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
Conversation
orlangur
requested changes
Feb 28, 2018
Contributor
orlangur
left a comment
There was a problem hiding this comment.
Please adopt corresponding test by fixing existing case and also add a new one, with empty currency symbol.
As always, please do amend commit and force push.
Member
Author
|
@orlangur, I fixed the test and submitted an issue with instructions on how to reproduce the problem. Regarding a separate test with an empty currency-symbol, doesn't seem like it makes sense in the context of this fix, since the whole idea is to stop using currency-symbol and use currency-code for caching. |
Contributor
|
@evgk ok, looks like there is quite low probability of regression in this place. |
orlangur
approved these changes
Mar 9, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
Contributor
magento-team
pushed a commit
that referenced
this pull request
Mar 16, 2018
This was referenced Mar 20, 2018
This was referenced Jun 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using getCurrencySymbol() leads to a bug for currencies where there is no currency symbol - cache ends up being non-unique. Using currency code for caching is a more foolproof way.
Contribution checklist