Skip to content

[Backport] Refactored javascript code of admin notification modal popup#15863

Merged
magento-engcom-team merged 3 commits intomagento:2.1-developfrom
RahulKachhadia:2.1-develop-PR-port-15341
Jun 19, 2018
Merged

[Backport] Refactored javascript code of admin notification modal popup#15863
magento-engcom-team merged 3 commits intomagento:2.1-developfrom
RahulKachhadia:2.1-develop-PR-port-15341

Conversation

@RahulKachhadia
Copy link
Copy Markdown
Contributor

@RahulKachhadia RahulKachhadia commented Jun 5, 2018

Original Pull Request

#15341

Description

  • Refactored javascript code from popup.phtml according to Magento way.
  • Created a JS component file js/system/messages/popup.js

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@RahulKachhadia RahulKachhadia requested a review from osrecio June 5, 2018 18:16
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jun 6, 2018
@VladimirZaets
Copy link
Copy Markdown
Contributor

VladimirZaets commented Jun 12, 2018

Hi, @rahul-kachhadiya, I took your PR into processing, thank you for collaboration.

@osrecio osrecio removed their request for review June 13, 2018 13:02
@magento-engcom-team magento-engcom-team merged commit f82e844 into magento:2.1-develop Jun 19, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 19, 2018
ENGCOM-1888: [Backport] Refactored javascript code of admin notificat…
788a597 
…ion modal popup #15863
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 19, 2018

Hi @rahul-kachhadiya. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

@RahulKachhadia RahulKachhadia deleted the 2.1-develop-PR-port-15341 branch June 19, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VladimirZaets VladimirZaets

Labels

Area: Frontend Component: AdminNotification Progress: accept Release Line: 2.1

Projects

None yet

Milestone

Release: 2.1.15

Development

Successfully merging this pull request may close these issues.

4 participants

@RahulKachhadia @VladimirZaets @magento-engcom-team @gelanivishal