Skip to content

Refactored javascript code of admin notification modal popup#15341

Merged
magento-engcom-team merged 3 commits intomagento:2.2-developfrom
RahulKachhadia:rahul-kachhadiya-patch-1
May 22, 2018
Merged

Refactored javascript code of admin notification modal popup#15341
magento-engcom-team merged 3 commits intomagento:2.2-developfrom
RahulKachhadia:rahul-kachhadiya-patch-1

Conversation

@RahulKachhadia
Copy link
Copy Markdown
Contributor

Description

  • Refactored javascript code from popup.phtml according to Magento way.
  • Created a JS component file js/system/messages/popup.js

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented May 19, 2018

CLA assistant check
All committers have signed the CLA.

@VladimirZaets
Copy link
Copy Markdown
Contributor

Hi, @rahul-kachhadiya, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rahul-kachhadiya. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants