Skip to content

[Forwardport] [Correct code formatting]#15813

Closed
hitesh-wagento wants to merge 14 commits intomagento:2.3-developfrom
hitesh-wagento:2.3-develop-PR-port-15811
Closed

[Forwardport] [Correct code formatting]#15813
hitesh-wagento wants to merge 14 commits intomagento:2.3-developfrom
hitesh-wagento:2.3-develop-PR-port-15811

Conversation

@hitesh-wagento
Copy link
Copy Markdown
Contributor

Original Pull Request

#15811

This PR is a:

  • Bug fix or improvement

Summary

Correct Code formatting.

Additional information

NA

[Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme…
[Forwardport] [Changed indentation 2 to 4]
@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 5, 2018
@orlangur orlangur self-assigned this Jun 5, 2018
Max Gopey and others added 6 commits June 5, 2018 10:21
[Forwardport] Add missing table aliases to fields mapping for Customer Group filter…
[Forwardport] [Resolved : limiter float too generic]
[Forwardport] [Resolved : Changing @tab-content__border variable has no effect in B…
@hitesh-wagento
Copy link
Copy Markdown
Contributor Author

@orlangur Could you please check what cause failed travis?

Thanks,

@hitesh-wagento
Copy link
Copy Markdown
Contributor Author

Hello @orlangur

Any update in this PR ?

Thanks

@orlangur orlangur mentioned this pull request Jun 12, 2018
1 task
@orlangur
Copy link
Copy Markdown
Contributor

@hitesh-wagento same PR targeting 2.2-develop should be processed first.

@orlangur
Copy link
Copy Markdown
Contributor

orlangur commented Jun 12, 2018

@hitesh-wagento please force push into this branch once PR targeting 2.2-develop is merged, currently there are unintended changes in Customer di.xml here.

@hitesh-wagento
Copy link
Copy Markdown
Contributor Author

@orlangur Could you please check what cause failed travis?

Thanks,

@orlangur orlangur added this to the Release: 2.3.0 milestone Jun 14, 2018
@orlangur
Copy link
Copy Markdown
Contributor

@hitesh-wagento no, you are supposed to do it.

Closing as this PR contains changes not related to original PR. Please use a tool to create a port.

@orlangur orlangur closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: reject

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants