[Forwardport] Remove unused namespace from ui export#15611
Closed
dmytro-ch wants to merge 1 commit intomagento:2.2-developfrom
Closed
[Forwardport] Remove unused namespace from ui export#15611dmytro-ch wants to merge 1 commit intomagento:2.2-developfrom
dmytro-ch wants to merge 1 commit intomagento:2.2-developfrom
Conversation
rogyar
suggested changes
May 31, 2018
| { | ||
| /** | ||
| * @var WriteInterface | ||
| * @var DirectoryList |
Contributor
There was a problem hiding this comment.
Seems like there's some mistake. In the constructor we init $directory property as a result of $filesystem->getDirectoryWrite() method, which creates an instance of Magento\Framework\Filesystem\Directory\Write using the corresponding factory. So, basically, it returns WriteInterface but not DirectoryList. The same situation is for the ConvertToXml class.
Please, correct me if I'm wrong.
Contributor
Author
|
@rogyar thank you for notice. You are right. We should close this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15240
Description
The Export model have some unused namespaces:
Magento\Framework\Filesystem\Directory\WriteInterface.Just removing it and update description
Manual testing scenarios
Contribution checklist