Skip to content

Remove unused namespace from ui export#15240

Merged
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
Atwix:remove-unused-namespace-from-ui-export
May 16, 2018
Merged

Remove unused namespace from ui export#15240
magento-engcom-team merged 1 commit intomagento:2.1-developfrom
Atwix:remove-unused-namespace-from-ui-export

Conversation

@yuriyDne
Copy link
Copy Markdown

@yuriyDne yuriyDne commented May 16, 2018

Description

The Export model have some unused namespaces: Magento\Framework\Filesystem\Directory\WriteInterface.
Just removing it and update description

Manual testing scenarios

  1. For example, go to orders list;
  2. Export list of order by XML or CSV;
  3. All should export as expected.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented May 16, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@yuriyDne thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @yuriyDne. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants