Skip to content

Adding manners to GitHub templates 2.2#15462

Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
dmanners:adding-manners-to-github-templates-2-2
May 25, 2018
Merged

Adding manners to GitHub templates 2.2#15462
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
dmanners:adding-manners-to-github-templates-2-2

Conversation

@dmanners
Copy link
Copy Markdown
Contributor

@dmanners dmanners commented May 23, 2018

Description

Update the pull request and issue template for github to be a bit clearer.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #15387 and #15450

dmanners added 2 commits May 23, 2018 14:23
…nd expected results

 - Making it so that screenshots and logs are optional
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @dmanners. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants