Skip to content

ADHOC: update the contribution templates#15387

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
dmanners:adding-manners-to-github-templates
May 21, 2018
Merged

ADHOC: update the contribution templates#15387
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
dmanners:adding-manners-to-github-templates

Conversation

@dmanners
Copy link
Copy Markdown
Contributor

Description

After watching a great talk about contribution 101 by @sunshinejr I thought I would try to make our contribution templates a little clearer and encouraging to contributors. For this I have updated our pull request and issue templates.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @dmanners. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@sriesterer
Copy link
Copy Markdown

Hi @dmanners! Under "Expected result" you added screenshots and logs. That's not doable in all cases, right?
I'd make that "Screenshots, logs or description" to clarify that the former two are not absolutely required if not available.

@dmanners
Copy link
Copy Markdown
Contributor Author

Thank you @sriesterer for that feedback. I will update this when I get a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants