Resolve Knockout non-unique elements id in console error#15349
Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom Jun 2, 2018
neeta-wagento:feature-resolve-knockout-non-unique-id-console-error
Merged
Resolve Knockout non-unique elements id in console error#15349magento-engcom-team merged 2 commits intomagento:2.2-developfrom neeta-wagento:feature-resolve-knockout-non-unique-id-console-error
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
neeta-wagento:feature-resolve-knockout-non-unique-id-console-error
Conversation
Contributor
Author
|
Hello @miguelbalparda , |
Contributor
|
Hi @neeta-wagento, I working on your PR. Our internal tests are failed. Some functionality uses this ID, I will fix it and after that we will move PR to |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 2, 2018
- fix functional test.
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 2, 2018
Contributor
|
Hi @neeta-wagento. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This was referenced Jun 4, 2018
Merged
4 tasks
dangron
pushed a commit
to Space48/magento2-patches
that referenced
this pull request
Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabling more than one payment methods from admin, It is giving an error in the console "Found elements with non-unique id billing-address-form "
Description
Fixed Issues (if relevant)
Manual testing scenarios
Expected Result
It should not show any error in the console
Actual result
Contribution checklist