Ensure that each billing address form DOM element has a unique id#8
Merged
joshdifabio merged 1 commit intomasterfrom Jun 12, 2018
Merged
Ensure that each billing address form DOM element has a unique id#8joshdifabio merged 1 commit intomasterfrom
joshdifabio merged 1 commit intomasterfrom
Conversation
Contributor
Author
$ composer update space48/magento2-patches
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
- Installing space48/magento2-patches (dev-patch-magento2-issue-15349 ba135a4): Cloning ba135a46a8 from cache
Package sjparkinson/static-review is abandoned, you should avoid using it. Use phpro/grumphp instead.
Writing lock file
Generating autoload files
Processing patches configuration
- Applying patches for magento/module-checkout (1)
~ space48/magento2-patches: patches/Magento_Checkout/billing-address-form.patch [NEW]
Ensure that each billing address form DOM element has a unique id https://github.com/magento/magento2/pull/15349
- Applying patches for magento/module-configurable-product (1)
~ space48/magento2-patches: patches/Magento_ConfigurableProduct/magento2-issue-11953.patch [NEW]
Add frontend validation for SKU on configurable product variation generation in admin panel
- Applying patches for magento/module-swatches (1)
~ space48/magento2-patches: patches/Magento_Swatches/12036.patch [NEW]
prevent attribute beforesave plugin from nulling attribute options
Writing patch info to install file$ git diff vendor/magento/module-checkout/view/frontend/web/template/billing-address/form.html
diff --git a/vendor/magento/module-checkout/view/frontend/web/template/billing-address/form.html b/vendor/magento/module-checkout/view/frontend/web/template/billing-address/form.html
index 1be754934..1568045d4 100644
--- a/vendor/magento/module-checkout/view/frontend/web/template/billing-address/form.html
+++ b/vendor/magento/module-checkout/view/frontend/web/template/billing-address/form.html
@@ -9,7 +9,7 @@
<!-- ko template: getTemplate() --><!-- /ko -->
<!--/ko-->
<form data-bind="attr: {'data-hasrequired': $t('* Required Fields')}">
- <fieldset id="billing-new-address-form" class="fieldset address">
+ <fieldset data-bind="attr: { id:'billing-new-address-form-'+index, value:index}" class="fieldset address">
<!-- ko foreach: getRegion('additional-fieldsets') -->
<!-- ko template: getTemplate() --><!-- /ko -->
<!--/ko--> |
joshdifabio
approved these changes
Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
magento/magento2#15349