Error 500 in Module Manager #15211

flancer64 · 2018-05-15T06:59:11Z

Description

There is an error in Module Manager (http://store.com/setup/index.php/moduleGrid/modules) if some module has no "moduleName" property:

{
  "name": "amzn\/amazon-pay-and-login-magento-2-module",
  "type": "magento2-module",
  "version": "2.0.4"
}

Fixed Issues (if relevant)

Module Manager module grid is not working Magento 2.2.4 #15192

Manual testing scenarios

Module Manager doesn't show module grid when going through below step:

System > Tools > Web Setup Wizard > Module Manager

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

There is an error in Module Manager (http://store.com/setup/index.php/moduleGrid/modules) if some module has no "moduleName" property: ``` { "name": "amzn\/amazon-pay-and-login-magento-2-module", "type": "magento2-module", "version": "2.0.4" } ```

rogyar · 2018-05-15T08:08:46Z

setup/src/Magento/Setup/Model/Grid/Module.php

@@ -178,7 +178,7 @@ private function getModulesInfo(array $moduleList)
    private function addGeneralInfo(array $items)
    {
        foreach ($items as &$item) {
-            $item['moduleName'] = $item['moduleName'] ?: $this->packageInfo->getModuleName($item['name']);
+            $item['moduleName'] = isset($item['moduleName']) ? $item['moduleName'] : $this->packageInfo->getModuleName($item['name']);


The line length exceeds 120 characters. According to PSR-2 coding style, a line length must be <= 120 characters. Also as an improvement, I would recommend using null coalescing operator to simplify the construction (http://php.net/manual/en/language.operators.comparison.php#language.operators.comparison.coalesce)

rogyar · 2018-05-15T08:10:28Z

Hello @flancer64. Thank you for your collaboration. Please, consider fixing issues mentioned in the review. Also, adjust the PR description using the template you have upon the PR creation which includes Fixed Issues, Steps to Reproduce and other required sections.
Thank you

flancer64 · 2018-05-15T10:24:34Z

Hi, guys. Thanks for your responses. Feel free to change this code as you wish. It is just my proposal to fix the bug.

magento-engcom-team · 2018-05-21T14:29:28Z

@flancer64 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

hostep · 2018-05-21T16:29:25Z

@flancer64: can you edit your opening post, follow the template and add issue #15192 under the Fixed Issues (if relevant) so that issue automatically gets marked as fixed when this PR gets approved.

Thanks for the fix!

flancer64 · 2018-05-21T16:46:10Z

@hostep , done.

flancer64 · 2018-05-21T16:49:04Z

@magento-engcom-team , done.

magento-engcom-team · 2018-05-25T07:40:05Z

Hi @flancer64. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Donnerberg · 2018-05-30T13:19:33Z

I am having same problem Screenshoot: http://prntscr.com/jojvx0

But changing module.php line 181 did not solved my problem.

Does any1 have any other idea ?

Many thanks.
Nikola

flancer64 · 2018-05-30T14:06:03Z

PHP version? ?? is a 7.x feature. Try to get error message from web server error log, not from browser console.

Donnerberg · 2018-05-30T14:16:54Z

There is nothing in log files: http://prntscr.com/jokvek
( At least nothing when I press Module Manager button )

My PHP version is 7.0. I can upgrade it to version 7.1 if I need.

flancer64 · 2018-05-30T14:44:03Z

No, not in Magento logs. Try to look up for error message in /var/log/[apache2|nginx]/your_host_error.log

Donnerberg · 2018-05-30T14:53:01Z

Hm,

I'm going to find apache log files.

For now I have found only this: http://prntscr.com/jolgx0

flancer64 · 2018-05-30T17:10:49Z

Does the file /usr/home/donner/www_logs/donnerber.net/error.log exist?

Donnerberg · 2018-05-31T08:05:57Z

error.log.20180530.gz
I found log files at exactly location.

Before I downloaded log files, I have initiated Module Manager a few times.

Is there anything which could tell where is the problem ?

flancer64 · 2018-05-31T08:52:26Z

Sorry, @Donnerberg , I see nothing in error log. Could you give me an access log? We need to found request with HTTP result code 500.

Donnerberg · 2018-05-31T11:06:56Z

access.log.20180530.gz

Oh, I should send you both. I hope there is something what could help.

Many thanks for helping me with this.

1day older access log file you could find here:
access.log.20180529.gz

flancer64 · 2018-05-31T11:38:05Z

Sorry, @Donnerberg . I see that these error log & access log are from one server but I cannot see the error message in the log. Did you try to go directly to the URL "http://donnerberg.net.dedivirt595.your-server.de/setup/index.php/module-grid" under admin account (authorized)? You should see smth. like

If you will not see & will get error 500 try to debug app. Set breakpoint in ./setup/src/Magento/Setup/Controller/ModuleGrid.php (if you will go down to this class without errors).

Donnerberg · 2018-05-31T13:01:10Z

Yes you were right: http://prntscr.com/jp0tpm

But I am not sure how to set breakpoint in ./setup/src/Magento/Setup/Controller/ModuleGrid.php ?

flancer64 · 2018-05-31T13:43:56Z

I suppose, you can't if you ask me about it. Perhaps, nobody can, if this server is not under your full control. The last thing I can advise to you - try to look into the HTTP response (this is Dev tools in Chrome - Ctrl + Shift + I):

Donnerberg · 2018-05-31T13:52:40Z

Dear Flancer,

I have full access SSH and FTP control of server.

This is error from Network: http://prntscr.com/jp1vk8

What do you think about that ?

flancer64 · 2018-05-31T14:06:45Z

@Donnerberg , do you have "root" access?

You need to click on entry with error (red one) then go to tab "Response".

Donnerberg · 2018-05-31T14:26:59Z

@flancer64 , Yes I have full root access.

Here is screenshoot of response tab: http://prntscr.com/jp2f8u

flancer64 · 2018-06-01T10:47:00Z

Try to setup remote debugging then walk through the code starting from ./setup/index.php

Error 500 in Module Manager

a95034a

There is an error in Module Manager (http://store.com/setup/index.php/moduleGrid/modules) if some module has no "moduleName" property: ``` { "name": "amzn\/amazon-pay-and-login-magento-2-module", "type": "magento2-module", "version": "2.0.4" } ```

rogyar requested changes May 15, 2018

View reviewed changes

rogyar self-assigned this May 15, 2018

Fixed according to review

131a458

sidolov self-assigned this May 21, 2018

magento-engcom-team added this to the May 2018 milestone May 21, 2018

magento-engcom-team added the Release Line: 2.2 label May 21, 2018

hostep mentioned this pull request May 21, 2018

Module Manager module grid is not working Magento 2.2.4 #15192

Closed

magento-engcom-team added the Progress: accept label May 23, 2018

magento-engcom-team merged commit 131a458 into magento:2.2-develop May 25, 2018

magento-engcom-team pushed a commit that referenced this pull request May 25, 2018

ENGCOM-1633: Error 500 in Module Manager #15211

adf80bc

This was referenced Jun 4, 2018

[Forwardport] Error 500 in Module Manager vijay-wagento/magento2#18

Merged

[Backport] Error 500 in Module Manager vijay-wagento/magento2#19

Merged

[Forwardport] Error 500 in Module Manager #15755

Merged

[Backport] Error 500 in Module Manager #15756

Merged

hostep mentioned this pull request Jun 28, 2018

Module Manager grid is not working Magento 2.2.5 #16439

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error 500 in Module Manager #15211

Error 500 in Module Manager #15211

flancer64 commented May 15, 2018 •

edited

Loading

rogyar May 15, 2018

rogyar commented May 15, 2018 •

edited

Loading

flancer64 commented May 15, 2018

magento-engcom-team commented May 21, 2018

hostep commented May 21, 2018

flancer64 commented May 21, 2018

flancer64 commented May 21, 2018

magento-engcom-team commented May 25, 2018

Donnerberg commented May 30, 2018

flancer64 commented May 30, 2018

Donnerberg commented May 30, 2018

flancer64 commented May 30, 2018

Donnerberg commented May 30, 2018

flancer64 commented May 30, 2018

Donnerberg commented May 31, 2018

flancer64 commented May 31, 2018

Donnerberg commented May 31, 2018

flancer64 commented May 31, 2018

Donnerberg commented May 31, 2018

flancer64 commented May 31, 2018

Donnerberg commented May 31, 2018

flancer64 commented May 31, 2018

Donnerberg commented May 31, 2018

flancer64 commented Jun 1, 2018

Error 500 in Module Manager #15211

Error 500 in Module Manager #15211

Conversation

flancer64 commented May 15, 2018 • edited Loading

Description

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

rogyar May 15, 2018

Choose a reason for hiding this comment

rogyar commented May 15, 2018 • edited Loading

flancer64 commented May 15, 2018

magento-engcom-team commented May 21, 2018

hostep commented May 21, 2018

flancer64 commented May 21, 2018

flancer64 commented May 21, 2018

magento-engcom-team commented May 25, 2018

Donnerberg commented May 30, 2018

flancer64 commented May 30, 2018

Donnerberg commented May 30, 2018

flancer64 commented May 30, 2018

Donnerberg commented May 30, 2018

flancer64 commented May 30, 2018

Donnerberg commented May 31, 2018

flancer64 commented May 31, 2018

Donnerberg commented May 31, 2018

flancer64 commented May 31, 2018

Donnerberg commented May 31, 2018

flancer64 commented May 31, 2018

Donnerberg commented May 31, 2018

flancer64 commented May 31, 2018

Donnerberg commented May 31, 2018

flancer64 commented Jun 1, 2018

flancer64 commented May 15, 2018 •

edited

Loading

rogyar commented May 15, 2018 •

edited

Loading