Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Manager module grid is not working Magento 2.2.4 #15192

Closed
jignesh-baldha opened this issue May 14, 2018 · 24 comments
Closed

Module Manager module grid is not working Magento 2.2.4 #15192

jignesh-baldha opened this issue May 14, 2018 · 24 comments
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@jignesh-baldha
Copy link
Member

Preconditions

  1. Magento Version 2.2.4
  2. PHP Version 7.0.30
  3. MySQL version 5.7.22
  4. Apache/2.4.18 (Ubuntu)

Steps to reproduce

  1. I've installed latest Magento ver 2.2.4
  2. Module Manager doesn't show module grid when going through below step:
  • System > Tools > Web Setup Wizard > Module Manager

Expected result

  1. It should show manage module grid.

Actual result

2018_05_14_manage_module
Console shows following error
GET http://127.0.0.1/magento224/setup/index.php/moduleGrid/modules 500 (Internal Server Error)

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 14, 2018
@DigitalStartupUK
Copy link

I too am able to reproduce this.

@hostep
Copy link
Contributor

hostep commented May 14, 2018

Hi guys, can you please take a look in the log files of your webserver (apache/nginx/...), because "Internal Server Errors" are getting logged over there. Those log files will probably give you more info about what's wrong.

@DigitalStartupUK
Copy link

Nothing in Apache logs is being generated. I can't do a deep dive in this instance as I'm looking at a Shared Hosting Account that I use for Sandboxing. I don't particularly want to try and reproduce this on my Production/Dev Dedicated servers. Perhaps @jignesh-baldha can produce logs.

@ghost
Copy link

ghost commented May 15, 2018

I am having same issue on Fresh Install of Magento CE 2.2.4 with PHP 7.1.6

JS is No Where (500) for ....../setup/index.php/moduleGrid/modules

@evagabond
Copy link

Facing the same issues using Magento CE 2.2.4 & PHP 7.0.28

@ghost
Copy link

ghost commented May 15, 2018

@hostep , No logs in apache.

@jignesh-baldha
Copy link
Member Author

@hostep Not found any error in apache logs.

@hostep
Copy link
Contributor

hostep commented May 16, 2018

Ok, and how about the log locations of your Magento installation, for example in:

  • var/log/
  • var/report/

Also: if you take a look in your inspector to the network tab and you see that request which throws a 500 error, can you take a look at the response if something interesting is in there?

@donos0
Copy link

donos0 commented May 16, 2018

Fresh Magento CE 2.2.4 install with PHP 7.0.25 + Apache 2.4.29.
Same error as all above.
No logs in apache or in Magento. No report in Magento.

The console error message goes a bit further, though:
console
angular

@AndyJAllen
Copy link

AndyJAllen commented May 16, 2018

You guys can get further than I can. I get HTTP ERROR 500 when trying to just access the Web Setup Wizard on 2.2.4. I updated via composer.

@donos0
Copy link

donos0 commented May 19, 2018

Could this be anyhow related to issues #4546 and #4575 ?

@rishabhchd19
Copy link

same problem here.

@hostep
Copy link
Contributor

hostep commented May 21, 2018

Hi guys, I just saw this PR which seems to fix this problem: #15211
Can someone confirm that changing that one line fixes the problem? Thanks!

@DigitalStartupUK
Copy link

DigitalStartupUK commented May 21, 2018

@hostep I can confirm that this does "fix" the issue. Looks like it's down to the new Amazon Pay component (amzn/amazon-pay-and-login-magento-2-module). But this shouldn't be considered an actual fix for anyone thinking about changing the core code.

Thank you by-the-way, @hostep

@hostep
Copy link
Contributor

hostep commented May 21, 2018

Thanks for confirming @DigitalStartupUK, great! So if the PR gets approved it should get released in an upcoming new version. I agree this isn't the correct fix to edit the core files, this was only for verifying if it fixes the issue. People should consider for themselves how to workaround the issue, or just wait for a new version to be released in which the fix is included.

@sidolov
Copy link
Contributor

sidolov commented May 25, 2018

Hi @jignesh-baldha. Thank you for your report.
The issue has been fixed in #15211 by @flancer64 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your report.
The issue has been fixed in #15756 by @vijay-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 6, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 6, 2018

Hi @jignesh-baldha. Thank you for your report.
The issue has been fixed in #15755 by @vijay-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@jissereitsma
Copy link
Contributor

I've bumped into the same issue with Magento 2.2.5 which was just released today. The issue is not fixed. However, the fix mentioned above does work for me.

@Jacob-Wilsons
Copy link

I can confirm, the issue with blank page on "Module Manager" is still in magento 2.2.5

@Shellanza
Copy link

Hi there, I can confirm same issue still with 2.2.5 here.

@rishabhchd19
Copy link

rishabhchd19 commented Sep 12, 2018

Hi there, I can confirm same issue still with 2.2.5 here.

@Shellanza and @Jacob-Wilsons The changes have been made and tested successfully. Please go to setup/src/Magento/Setup/Model/Grid/Module.php

Change from:
$item['moduleName'] = $item['moduleName'] ?:$this->packageInfo->getModuleName($item['name']);

Change to:
$item['moduleName'] = $item['moduleName'] ?? $this->packageInfo->getModuleName($item['name']);

at line 181

@key-dev
Copy link

key-dev commented Sep 18, 2018

Hi there, I can confirm same issue still with 2.2.5 here.

@Shellanza and @Jacob-Wilsons The changes have been made and tested successfully. Please go to setup/src/Magento/Setup/Model/Grid/Module.php

Change from:
$item['moduleName'] = $item['moduleName'] ?:$this->packageInfo->getModuleName($item['name']);

Change to:
$item['moduleName'] = $item['moduleName'] ?? $this->packageInfo->getModuleName($item['name']);

at line 181

It worked.
Thank you

@tarunatbasics
Copy link

As key-dev said, I have changed 181 line of Module.php but the problem is still there, can anyone have a solution to this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests