7399-clickableOverlay-less-fix - added pointer-events rule to .modal-…#15172
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom May 16, 2018
Conversation
…popup class to let user click deeper than modals and reach to overlay's div in modal-wrapper div
Contributor
Contributor
|
Hi @virtua-pmakowski. Thank you for your contribution. |
This was referenced Jul 9, 2018
|
I do not see this code change when I updated to Magento 2.2.5 |
This was referenced Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…popup class to let user click deeper than modals and reach to overlay's div in modal-wrapper div
To reproduce issue please see: #7399
Description
Problem: modal's overlay div would not catch click event because is covered by modal's div above. That's why modal is would not fire close event when user is clicking outside modal.
My proposition of solution for that issue is add pointer-events: none css rule to modals in theme's less files.
Fixed Issues (if relevant)
Test scenario
... add a js script code
Contribution checklist