Can't scroll in modal popup on i os by priti2jcommerce · Pull Request #21150 · magento/magento2

priti2jcommerce · 2019-02-12T12:50:09Z

Description (*)

Fixed Issues (if relevant)

Can't scroll in modal-popup on iOS #21147: Can't scroll in modal-popup on iOS
...

Manual testing scenarios (*)

Try to scrolling in the popup on an iPhone (tested on iPhone 6s Plus & iPhone X)
...

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2019-02-12T12:50:12Z

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

priti2jcommerce · 2019-02-12T12:58:03Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-02-12T12:58:07Z

Hi @priti2jcommerce. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-02-12T12:58:40Z

Hi @priti2jcommerce, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Karlasa

@priti2jcommerce
Thanks for your fix. Your PR basically reverts PR #16664
So could be make both fixes work at the same time :)
I would suggest to not remove "pointer-events: none;" but just move it under media min @screen__m so closing modal on clicking outside of popup could work on tablet/desktop.

Cheers,

priti2jcommerce · 2019-02-13T05:16:35Z

Hi @Karlasa

Thanks for the update, made the changes for it.

Karlasa · 2019-02-13T09:26:39Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-02-13T09:26:45Z

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-02-13T09:27:24Z

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Karlasa · 2019-02-13T10:37:50Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-02-13T10:38:02Z

Hi @Karlasa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-02-13T10:38:36Z

Hi @Karlasa, here is your Magento instance.
Admin access: https://i-21150-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Karlasa · 2019-02-13T20:47:36Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-02-13T20:47:37Z

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-02-13T20:48:36Z

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Karlasa · 2019-02-14T09:37:19Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-02-14T09:37:22Z

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-02-14T09:38:20Z

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

dmytro-ch · 2019-02-14T12:15:44Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-02-14T12:15:46Z

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-02-14T12:16:30Z

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

magento-engcom-team · 2019-02-14T12:37:04Z

Hi @Karlasa, thank you for the review.
ENGCOM-4261 has been created to process this Pull Request

sidolov · 2019-04-10T18:14:08Z

Hi @priti2jcommerce looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

priti2jcommerce · 2019-04-16T05:24:07Z

Hi @sidolov ,

committed changes from GitHub profile are here
Can you please confirm?
Thanks!

magento-engcom-team · 2019-04-17T16:11:47Z

Hi @sidolov, thank you for the review.
ENGCOM-4775 has been created to process this Pull Request

soleksii · 2019-04-18T09:33:42Z

✔️ QA Passed

Before:

After:

…-in-modal-popup-on-iOS

m2-assistant · 2019-04-28T22:11:47Z

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Area: Design/Frontend Release Line: 2.3 Partner: Two Jay partners-contribution Pull Request is created by Magento Partner labels Feb 12, 2019

Karlasa self-assigned this Feb 12, 2019

Karlasa suggested changes Feb 12, 2019

View reviewed changes

Karlasa suggested changes Feb 13, 2019

View reviewed changes

Comment thread app/design/frontend/Magento/blank/web/css/source/components/_modals_extend.less Outdated

Karlasa reviewed Feb 14, 2019

View reviewed changes

Comment thread app/design/frontend/Magento/blank/web/css/source/components/_modals_extend.less Outdated

Karlasa approved these changes Feb 14, 2019

View reviewed changes

ghost unassigned Karlasa and soleksii Apr 4, 2019

sidolov approved these changes Apr 17, 2019

View reviewed changes

ghost assigned sidolov Apr 17, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 17, 2019

soleksii self-assigned this Apr 18, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Apr 18, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Apr 18, 2019

p-bystritsky self-assigned this Apr 18, 2019

p-bystritsky removed their assignment Apr 25, 2019

nmalevanec self-assigned this Apr 25, 2019

Merge remote-tracking branch 'mainline/2.3-develop' into Can't-scroll…

85026a4

…-in-modal-popup-on-iOS

ghost added Progress: accept and removed Progress: extended testing labels Apr 26, 2019

magento-engcom-team added the Award: bug fix label Apr 28, 2019

sivaschenko added 2 commits April 28, 2019 19:35

magento#21150: Fixed static tests

692cd9d

magento#21150: Fixed static tests

ee8778b

magento-engcom-team assigned sivaschenko Apr 28, 2019

magento-engcom-team mentioned this pull request Apr 28, 2019

Can't scroll in modal-popup on iOS #21147

Closed

magento-engcom-team merged commit ee8778b into magento:2.3-develop Apr 28, 2019

magento-engcom-team added this to the Release: 2.3.2 milestone Apr 28, 2019

magento-engcom-team pushed a commit that referenced this pull request Apr 28, 2019

ENGCOM-4775: Can't scroll in modal popup on i os #21150

569819a

Conversation

priti2jcommerce commented Feb 12, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

magento-engcom-team commented Feb 12, 2019

Uh oh!

priti2jcommerce commented Feb 12, 2019

Uh oh!

magento-engcom-team commented Feb 12, 2019

Uh oh!

magento-engcom-team commented Feb 12, 2019

Uh oh!

Karlasa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

priti2jcommerce commented Feb 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Karlasa commented Feb 13, 2019

Uh oh!

magento-engcom-team commented Feb 13, 2019

Uh oh!

magento-engcom-team commented Feb 13, 2019

Uh oh!

Uh oh!

Karlasa commented Feb 13, 2019

Uh oh!

magento-engcom-team commented Feb 13, 2019

Uh oh!

magento-engcom-team commented Feb 13, 2019

Uh oh!

Karlasa commented Feb 13, 2019

Uh oh!

magento-engcom-team commented Feb 13, 2019

Uh oh!

magento-engcom-team commented Feb 13, 2019

Uh oh!

Uh oh!

Karlasa commented Feb 14, 2019

Uh oh!

magento-engcom-team commented Feb 14, 2019

Uh oh!

magento-engcom-team commented Feb 14, 2019

Uh oh!

dmytro-ch commented Feb 14, 2019

Uh oh!

magento-engcom-team commented Feb 14, 2019

Uh oh!

magento-engcom-team commented Feb 14, 2019

Uh oh!

magento-engcom-team commented Feb 14, 2019

Uh oh!

sidolov commented Apr 10, 2019

Uh oh!

priti2jcommerce commented Apr 16, 2019

Uh oh!

magento-engcom-team commented Apr 17, 2019

Uh oh!

soleksii commented Apr 18, 2019

Uh oh!

m2-assistant Bot commented Apr 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Karlasa left a comment •

edited

Loading

priti2jcommerce commented Feb 13, 2019 •

edited

Loading