Fix infinite checkout loader when some script wasn't loaded correctly because of network error#14874
Conversation
|
@vovayatsyuk thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
```
require([
'ko',
'https://some-site/tracking/api/js'
], function () {});
```
…ded correctly because of network error #14874
|
Hi @vovayatsyuk. Thank you for your contribution. |
|
it still does not load checkout even in version 2.2.5 |
|
We are also seeing this issue in 2.2.5, with customers who have ad blockers installed (notably Ad Block Plus). |
|
@cbartak-rivet I'd recommend opening a new issue with a stack trace if you can replicate the issue. |
Description
Infinite checkout loader may appear when some module makes a
requirecall but the dependency wasn't returned (Network error).The patch changes how Magento treats
isPendingmodules. If all dependencies are errored - treat it as loaded.Manual testing scenarios
Magento/Checkout/view/frontend/web/js/model/quote.jsright after
Contribution checklist