Skip to content

[Forwardport] Fix infinite checkout loader when some script wasn't loaded correctly because of network error#4

Merged
adrian-martinez-interactiv4 merged 4 commits into2.3-developfrom
2.3-develop-PR-port-14874
Oct 8, 2018
Merged

[Forwardport] Fix infinite checkout loader when some script wasn't loaded correctly because of network error#4
adrian-martinez-interactiv4 merged 4 commits into2.3-developfrom
2.3-develop-PR-port-14874

Conversation

@adrian-martinez-interactiv4
Copy link
Copy Markdown
Owner

Original Pull Request

magento#14874

Description

Infinite checkout loader may appear when some module makes a require call but the dependency wasn't returned (Network error).

The patch changes how Magento treats isPending modules. If all dependencies are errored - treat it as loaded.

Manual testing scenarios

  1. Open Magento/Checkout/view/frontend/web/js/model/quote.js
  2. Insert the following code:
require([
    'jquery',
    'https://some-site/tracking/api/js'
], function ($) {}, function () {});

right after

define([
    'ko',
    'underscore'
], function (ko, _) {
    'use strict';

    // add code here
  1. Navigate to checkout.
  2. You can't purchase the product because the page is blocked by loader.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@adrian-martinez-interactiv4 adrian-martinez-interactiv4 merged commit 7ca617b into 2.3-develop Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants