[Forwardport] Fix infinite checkout loader when some script wasn't loaded correctly because of network error#4
Merged
adrian-martinez-interactiv4 merged 4 commits into2.3-developfrom Oct 8, 2018
Conversation
```
require([
'ko',
'https://some-site/tracking/api/js'
], function () {});
```
c3f23c4 to
7ca617b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#14874
Description
Infinite checkout loader may appear when some module makes a
requirecall but the dependency wasn't returned (Network error).The patch changes how Magento treats
isPendingmodules. If all dependencies are errored - treat it as loaded.Manual testing scenarios
Magento/Checkout/view/frontend/web/js/model/quote.jsright after
Contribution checklist