Fix for Issue #13950 - Cache issue with configurable products related to currency-conversions#14017
Closed
nuzil wants to merge 5 commits intomagento:2.2-developfrom
Closed
Fix for Issue #13950 - Cache issue with configurable products related to currency-conversions#14017nuzil wants to merge 5 commits intomagento:2.2-developfrom
nuzil wants to merge 5 commits intomagento:2.2-developfrom
Conversation
added 2 commits
March 7, 2018 19:35
…Product\Block\Product\View\Type\Configurable and Magento\CatalogWidget\Block\Product\ProductsList blocks: used currency code instead of currency symbol in cache key info array.
added 3 commits
March 26, 2018 12:52
… branch on github.
… branch on github.
Contributor
Author
|
Hi @orlangur |
Contributor
|
Thanks @nuzil, changes look good to me now. By "could you please rewrite this PR" I meant squashing into a single commit so that history is cleaner. Please do it and perform a force push into the same branch. |
Contributor
Author
|
Sorry we have a mess already in our own repository, I made a new PR This one can closed then |
Contributor
|
Closed according to comment above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preconditions.
Magento website with configured multiple currencies, for some of currencies not configured currency symbol.
Problem.
Two Magento block classes used in generating cache key (in method getCacheKeyInfo()) current currency symbol. It leads to problem that these blocks has same cache for different currencies which has no symbol configured.
Solution.
Use currency code instead currency symbol in cache key generating to get unique cache of these block for different currencies.