Skip to content

Add compare list link to success message after adding a product #13862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 3 commits into from
Jun 7, 2018
Merged

Add compare list link to success message after adding a product #13862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edd6062
Add a link to the success message when adding a product to the compar…
avstudnitz Feb 27, 2018
6c17f99
Renaming to avoid duplication
avstudnitz Feb 27, 2018
4c1bd49
Merge branch '2.2-develop' into compare-success-message
avstudnitz Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/code/Magento/Catalog/Controller/Product/Compare/Add.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,14 @@ public function execute()
$productName = $this->_objectManager->get(
\Magento\Framework\Escaper::class
)->escapeHtml($product->getName());
$this->messageManager->addSuccess(__('You added product %1 to the comparison list.', $productName));
$this->messageManager->addComplexSuccessMessage(
'addCompareSuccessMessage',
[
'product_name' => $productName,
'compare_list_url' => $this->_url->getUrl('catalog/product_compare')
]
);

$this->_eventManager->dispatch('catalog_product_compare_add_product', ['product' => $product]);
}

Expand Down
12 changes: 12 additions & 0 deletions app/code/Magento/Catalog/etc/frontend/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,18 @@
<argument name="typeId" xsi:type="string">recently_compared_product</argument>
</arguments>
</virtualType>
<type name="Magento\Framework\View\Element\Message\MessageConfigurationsPool">
<arguments>
<argument name="configurationsMap" xsi:type="array">
<item name="addCompareSuccessMessage" xsi:type="array">
<item name="renderer" xsi:type="const">\Magento\Framework\View\Element\Message\Renderer\BlockRenderer::CODE</item>
<item name="data" xsi:type="array">
<item name="template" xsi:type="string">Magento_Catalog::messages/addCompareSuccessMessage.phtml</item>
</item>
</item>
</argument>
</arguments>
</type>
<type name="Magento\Framework\App\ResourceConnection">
<plugin name="get_catalog_category_product_index_table_name" type="Magento\Catalog\Model\Indexer\Category\Product\Plugin\TableResolver"/>
</type>
Expand Down
14 changes: 14 additions & 0 deletions app/code/Magento/Catalog/view/frontend/templates/messages/addCompareSuccessMessage.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// @codingStandardsIgnoreFile
/** @var \Magento\Framework\View\Element\Template $block */
?>
<?= $block->escapeHtml(__(
'You added product %1 to the <a href="%2">comparison list</a>.',
$block->getData('product_name'),
$block->getData('compare_list_url')),
['a']
);
2 changes: 1 addition & 1 deletion dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function testAddAction()
);

$this->assertSessionMessages(
$this->equalTo(['You added product Simple Product 1 Name to the comparison list.']),
$this->equalTo(['You added product Simple Product 1 Name to the <a href="http://localhost/index.php/catalog/product_compare/">comparison list</a>.']),
MessageInterface::TYPE_SUCCESS
);

Expand Down