Add compare list link to success message after adding a product#13862
Merged
magento-engcom-team merged 3 commits intomagento:2.2-developfrom Jun 7, 2018
Merged
Conversation
Contributor
|
Very good PR. The same should be done when you add a product to your basket. (add link directly to checkout) :) |
Contributor
Author
|
@PieterCappelle Thanks for the hint, I'll work on it :-) |
Member
|
Hi @avstudnitz , Thanks for your contribution. I will work to process it. I'll keep you informed. |
# Conflicts: # app/code/Magento/Catalog/etc/frontend/di.xml
Contributor
|
Hi, when will this be merged? |
Member
|
Hi, Sorry, I lost this PR in my timeline. Now is Ready for Delivery. And soon will be merged. |
Contributor
|
Hi @avstudnitz. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If I add a product to the compare list, I want to go the compare list directly after that in many cases without having to search for a link. Thus, the link has been added to the success message now.
Manual testing scenarios
Contribution checklist