Fix : wrong sender for sales emails sent from BO

[benjamin-volle]

Fix for wrong sender when sending sales emails from BO for non-default stores

Description

The sales emails are always sent from default sender when sent via BO, even if the sender is overriden in configs

Manual testing scenarios

1. Change sales email sender for non-default store
2. Send "order confirmation" email from BO

[benjamin-volle]

Should I change the destination branch to "develop" ?

[avoelkl]

Hi @synolia-bvo,
Does the problem exist in 2.2 as well or only in 2.1?

[avoelkl]

Regarding your question:

Should I change the destination branch to "develop" ?

Please use either 2.2-developer or 2.1-develop (depending on where the problem exists). Thanks!

[benjamin-volle]

Hello,

The problem is still present in verison 2.2

I changed destination to 2.1-develop.

If the problem exists in both version, do i need to do this PR on both branches ?

[PieterCappelle]

Hi. I fixed a lot of this in PR #11307 and #11308.

[avoelkl]

I see you also added some scope/store id's @PieterCappelle.
If I saw correctly the only addition in this PR is setting the correct from-address ($result = $this->_senderResolver->resolve($from, $this->scopeId);)
Can you both please check as well, especially @synolia-bvo if the PR from Pieter also matches your goal?

[avoelkl]

If the problem exists in both version, do i need to do this PR on both branches ?
Yes, 2.1-developer and 2.2-develop would be great.

Otherwise, only 2.2-develop should be fine as well and it will be backported later.

[benjamin-volle]

Hi,

There is one modification that is not in @PieterCappelle 's PR in file app/code/Magento/Sales/Model/Order/Email/SenderBuilder.php

@PieterCappelle : can you please add this modification to yours ?

[PieterCappelle]

Done @synolia-bvo.

[benjamin-volle]

Thank you. So can I close my PR ?

[PieterCappelle]

Yes, but maybe wait until my PR is accepted?

[benjamin-volle]

Ok, I'll do this. Thanks !

[avoelkl]

Awesome, thanks @PieterCappelle @synolia-bvo!

Current status: Waiting to get PR #11307 and #11308 merged.

[benjamin-volle]

Hi all,

Is there any news for these issues ? @avoelkl

Thanks,

[avoelkl]

Hi @synolia-bvo,
As I can see the related PR's #11307 and #11308 have been closed.
Any news on this @PieterCappelle @okorshenko ?

[benjamin-volle]

Hi,

What should I do now ..?

[orlangur]

Issue was fixed for 2.2-develop in #14800 and can be backported based on it if still relevant.

[benjamin-volle]

@orlangur The fix you referenced doesn't fix the same problem. My fix was for "sales emails " (like orders or invoices), not for reset password.

[orlangur]

@synolia-bvo could you please report it if still relevant for 2.2-develop? All contributions nowadays should be merged to 2.2 release line first.

[benjamin-volle]

It looks fixed in 2.2 in this commit : f2bfdd9

[orlangur]

@synolia-bvo thanks for investigation! Then, if you really need it fixed in 2.1-develop, you can create a backport out of this fix.