Skip to content

[2.1-Develop] Fix for issue #5726#11307

Closed
PieterCappelle wants to merge 9 commits intomagento:2.1-developfrom
PieterCappelle:fix_2_1_issue_5726
Closed

[2.1-Develop] Fix for issue #5726#11307
PieterCappelle wants to merge 9 commits intomagento:2.1-developfrom
PieterCappelle:fix_2_1_issue_5726

Conversation

@PieterCappelle
Copy link
Copy Markdown
Contributor

@PieterCappelle PieterCappelle commented Oct 9, 2017 •
edited by okorshenko
Loading

Was fixed in 2.0.8 branch. Never got into 2.1-develop and 2.2-develop. Cherry-pick from 9fc059b

#5726

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

[2.1-Develop] Fix for issue #5726
6f5400f 
Was fixed in 2.0.8 branch. Never got into 2.1-develop and 2.2-develop. Cherry-pick from 9fc059b
@vrann vrann added this to the October 2017 milestone Oct 9, 2017
@okorshenko
Copy link
Copy Markdown
Contributor

okorshenko commented Oct 9, 2017

Hi @PieterCappelle
Could you please check failed unit tests?

@okorshenko okorshenko self-assigned this Oct 9, 2017
@PieterCappelle PieterCappelle mentioned this pull request Oct 11, 2017
Closed
@PieterCappelle
Copy link
Copy Markdown
Contributor Author

PieterCappelle commented Oct 15, 2017

Finally fixed all the unittests :-)

@okorshenko okorshenko added 2.2.x bug report Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 16, 2017
@okorshenko
Copy link
Copy Markdown
Contributor

okorshenko commented Oct 25, 2017

Hi @PieterCappelle
The QA team reported that GitHub issue #5726 is still reproducible on this branch. Could you please double check your fix. Thank you

@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@okorshenko
Copy link
Copy Markdown
Contributor

okorshenko commented Nov 6, 2017

Hi @PieterCappelle we are closing this PR for now. Please, reopen it once ready

@okorshenko okorshenko closed this Nov 6, 2017
@PieterCappelle PieterCappelle deleted the fix_2_1_issue_5726 branch December 21, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@okorshenko okorshenko

Labels

bug report Progress: needs update Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Milestone

November 2017

Development

Successfully merging this pull request may close these issues.

4 participants

@PieterCappelle @okorshenko @magento-team @vrann