Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cms page/block eventprefix fix issue 9900 #11223

Merged

Conversation

convenient
Copy link
Contributor

@convenient convenient commented Oct 4, 2017

Fix issue #9900 by defining eventPrefix and eventObject against collections.

This issue is fixed in the develop branch by #11046

This PR cherry-picks those commits into the 2.2-develop branch.

$ git cherry-pick a15f4cc7e77b672b94657620e7e961265160d103 bf0dbee9cc4483f212b9c5643f3e50df7a2214cd d782c711321a10879f4b0d24e6400a45ac04bed8 a87f1cfdc5907eac0185316636ebe99b800a1ac4
[cms-page-eventprefix-fix-issue-9900 08491d33e99] Add EventPrefix to CMS Page/Block Collection
 Author: Oscar Recio <[email protected]>
 Date: Tue Sep 26 11:17:51 2017 +0200
 2 files changed, 14 insertions(+)
[cms-page-eventprefix-fix-issue-9900 bc6180ca862] Add EventPrefix to CMS Page/Block Collection
 Author: Oscar Recio <[email protected]>
 Date: Tue Sep 26 11:29:20 2017 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
[cms-page-eventprefix-fix-issue-9900 e110196da16] Add EventObject to CMS Page/Block Collection
 Author: Oscar Recio <[email protected]>
 Date: Tue Sep 26 11:52:56 2017 +0200
 2 files changed, 15 insertions(+), 1 deletion(-)
[cms-page-eventprefix-fix-issue-9900 ce93e40ae2d] Add EventObject to CMS Page/Block Collection
 Author: Oscar Recio <[email protected]>
 Date: Tue Sep 26 11:54:08 2017 +0200
 1 file changed, 2 insertions(+), 2 deletions(-)

I'll see how this runs against travis, if it passes I'd consider this a success.

#SQUASHTOBERFEST

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@convenient convenient changed the title Cms page eventprefix fix issue 9900 Cms page/block eventprefix fix issue 9900 Oct 4, 2017
@okorshenko okorshenko self-assigned this Oct 4, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 4, 2017
@okorshenko
Copy link
Contributor

Hi @convenient
could you please accept invite from magento-team on the GitHub?

@convenient
Copy link
Contributor Author

@okorshenko

You now have view access to the magento/magento2 repository.

What changed?

@okorshenko
Copy link
Contributor

@convenient now we can assign issues to you
Please check this https://twitter.com/maksek_ua/status/915572031005057025

@convenient
Copy link
Contributor Author

@okorshenko thanks! That's what I get for pushing code before reading the associated documentation 😅

@okorshenko okorshenko merged commit ce93e40 into magento:2.2-develop Oct 4, 2017
@convenient convenient deleted the cms-page-eventprefix-fix-issue-9900 branch October 5, 2017 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants