Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventPrefix and EventObject to CMS Page/Block Collection #11046

Merged
merged 4 commits into from
Sep 27, 2017

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Sep 26, 2017

Add EventPrefix to CMS Page Collection and CMS Block Collection

Description

Added EvenPrefix and EventObject for CMS Collections for instantiate observer for $this->_eventPrefix . '_load_after' and $this->_eventPrefix . '_load_before'

Fixed Issues (if relevant)

  1. Cms module collections missing event prefix #9900

Manual testing scenarios

  1. Add Observer for Event: cms_page_collection_load_after
  2. Check Observer code is executed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio osrecio changed the title Add EventPrefix to CMS Page/Block Collection Add EventPrefix and EventObject to CMS Page/Block Collection Sep 26, 2017
@vkublytskyi vkublytskyi self-requested a review September 26, 2017 11:57
@vkublytskyi vkublytskyi self-assigned this Sep 26, 2017
@vkublytskyi vkublytskyi added this to the September 2017 milestone Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants