Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer-mode check to setup:upgrade command #11136

Closed
wants to merge 1 commit into from
Closed

Add developer-mode check to setup:upgrade command #11136

wants to merge 1 commit into from

Conversation

renttek
Copy link

@renttek renttek commented Sep 29, 2017

Add a check for application state/mode to setup:upgrade command.

Description

Add a check for application state/mode to setup:upgrade command.
If the mode is "developer" then don't show the di-recompile notice.
If mode is something other than "developer", show the notice.

Fixed Issues (if relevant)

  1. magento setup:upgrade prompts to run compilation, even in developer mode #11044: magento setup:upgrade prompts to run compilation, even in developer mode

Manual testing scenarios

  1. Set application mode to "developer" (bin/magento deploy:mode:set developer)

  2. Run CLI command "setup:upgrade"

  3. There should be no notice to re-run di-compile

  4. Set application mode to something other than "developer". e.g. "default" (bin/magento deploy:mode:set default)

  5. Run CLI command "setup:upgrade"

  6. There should be a notice to re-run di-compile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Add a check for application state/mode to setup:upgrade.
If the mode is "developer" then don't show the di-recompile notice.
If mode is something other than "developer", show the notice.
@dmanners
Copy link
Contributor

I guess this has already been covered by #11050 and #11047 for the develop and develop2.2 branch by @schmengler Interesting that you both picked slightly different boolean checks.

@renttek renttek closed this Sep 29, 2017
@renttek renttek deleted the issue/11044 branch October 1, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants