Add developer-mode check to setup:upgrade command #11136
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check for application state/mode to setup:upgrade command.
Description
Add a check for application state/mode to setup:upgrade command.
If the mode is "developer" then don't show the di-recompile notice.
If mode is something other than "developer", show the notice.
Fixed Issues (if relevant)
Manual testing scenarios
Set application mode to "developer" (bin/magento deploy:mode:set developer)
Run CLI command "setup:upgrade"
There should be no notice to re-run di-compile
Set application mode to something other than "developer". e.g. "default" (bin/magento deploy:mode:set default)
Run CLI command "setup:upgrade"
There should be a notice to re-run di-compile
Contribution checklist