Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only prompt for deploy command in production mode #11050

Merged
merged 3 commits into from
Oct 6, 2017
Merged

Only prompt for deploy command in production mode #11050

merged 3 commits into from
Oct 6, 2017

Conversation

schmengler
Copy link
Contributor

@schmengler schmengler commented Sep 26, 2017

This is a backport of #11047 for the 2.2 branch

Description

After running setup:upgrade command, the message "Please rerun Magento compile command" only shows up in production mode

Fixed Issues (if relevant)

  1. magento setup:upgrade prompts to run compilation, even in developer mode #11044: magento setup:upgrade prompts to run compilation, even in developer mode

Manual testing scenarios

  1. run bin/magento setup:upgrade in developer or default mode

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 29, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ schmengler
❌ paliarush
❌ viktym

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants