Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 status header #11134

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Conversation

Zifius
Copy link
Member

@Zifius Zifius commented Sep 29, 2017

Description

Changes 404 header status text to "Not Found" instead of wrong "Forbidden"

Fixed Issues (if relevant)

  1. 404 Forbidden sounds not right #10775: 404 Forbidden sounds not right

Manual testing scenarios

  1. Go to Catalog -> Products and click "Add Product" button
  2. On the page opened remove "set/4" from URL and hit enter
  3. In developer tools console observe "Not Found" hint when hovering 404 in the "Status" column

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Sep 30, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 1, 2017
@okorshenko okorshenko merged commit 70379e3 into magento:2.2-develop Oct 6, 2017
okorshenko pushed a commit that referenced this pull request Oct 6, 2017
@Zifius Zifius deleted the fix/issue-10775 branch May 28, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants