Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 Forbidden sounds not right #10775

Closed
irinikp opened this issue Sep 5, 2017 · 12 comments
Closed

404 Forbidden sounds not right #10775

irinikp opened this issue Sep 5, 2017 · 12 comments
Assignees
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@irinikp
Copy link

irinikp commented Sep 5, 2017

Preconditions

Magento 2.1

Steps to reproduce

Reopening Issue #5176 as it is still reproducible

capture

@kalpmehta
Copy link
Contributor

Make sure your hosting provider is not blocking it. Are you on nexcess?

@irinikp
Copy link
Author

irinikp commented Sep 6, 2017

Not on nexcess. I have a dedicated server, there is no blocking

@ekuusela
Copy link
Contributor

ekuusela commented Sep 7, 2017

The forbidden status is set here:

$resultPage->setStatusHeader(404, '1.1', 'Forbidden');

@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@irinikp thank you for your report.
Please use the issue reporting guidelines to report an issue. Please, edit issue description and include the preconditions, the steps required to reproduce, the actual result, and the expected result.
Please, add the following information:

  • Preconditions: Magento version
  • DETAILED Steps to reproduce and enviroument configuration
  • Expected result
  • Actual result

@magento-engcom-team magento-engcom-team self-assigned this Sep 13, 2017
@korostii
Copy link
Contributor

Hello again @magento-engcom-team
The comment above yours goes as far as pointing out the exact place in source code which ought to be fixed. Putting bureaucracy aside, that's more plenty enough information.

If you insist, it's insanely easy to reproduce: you can even access the page directly.
Here's a CE 2.1.8: http://take.ms/Cp62g

@orlangur
Copy link
Contributor

Looks like there was a copy-paste typo in 77ac45b. While 'up for grabs' is usually used for some huge necessary changes, would be nice to have some label like https://github.com/facebook/hhvm/issues?q=is%3Aopen+is%3Aissue+label%3A%22probably+easy%22 for smaller issues.

@orlangur orlangur added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Progress: needs update labels Sep 14, 2017
@magento-engcom-team
Copy link
Contributor

@korostii @ekuusela We always encourage you to submit a Pull Request if the fix is that easy.
Otherwise clear issue report is required, so that developer working can precisely identify issue and possible testing scenarios.
Thank you for understanding.

@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 22, 2017
@Zifius Zifius mentioned this issue Sep 29, 2017
4 tasks
@korostii
Copy link
Contributor

korostii commented Sep 29, 2017

@magento-engcom-team I think you're missing the point.
The issue was clearly valid and had just the right amount of information on it.
If it has plenty info for a PR (BTW thank you @Zifius for coming forward #11134 ), it should be enough of a "clear issue report".

Dismissing the issue after manual review with a comment that's clearly hostile (I mean, caps? http://take.ms/MWYka was that really necessary? ) because the formatting is not to your liking isn't an okay way to greet voluntary bug reports.

Don't we have a Code of Conduct which says that everyone should be, and I quote: "Gracefully accepting constructive criticism" and "Focusing on what is best for the community"?
IMHO that comment goes a little overboard with this urge to get the issue template right.

@ishakhsuvarov
Copy link
Contributor

I have to lock this conversation as it is now beyond

"Gracefully accepting constructive criticism"

Thanks for collaboration. Fix for the issue hopefully will be delivered with the next patch for 2.2.

@magento magento locked and limited conversation to collaborators Sep 29, 2017
@magento-engcom-team
Copy link
Contributor

Hi @irinikp the issue has been fixed in 2.2.1 and will be available soon (#11134)

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 6, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-80515

@magento-team magento-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Oct 6, 2017
@magento-team
Copy link
Contributor

Hi @irinikp. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1282 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

10 participants