Skip to content

Tokens-database refactoring #14142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JayDi85 merged 9 commits into from
Jan 25, 2026
Merged

Tokens-database refactoring #14142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4e18221
Begin by documenting the schema for tokens-database.txt
muz Dec 26, 2025
4fc85dd
Remove first unnecessary Generate column in tokens-database.txt. Shif…
muz Dec 26, 2025
6615a67
Correct tokens-database.txt schema
muz Dec 26, 2025
33e00ab
Include info on nullable columns, and strictly expect 5 params with t…
muz Dec 26, 2025
2591801
Extract non-nullable columns from tokens-database.txt and simplify va…
muz Dec 26, 2025
cf6d7d6
Validate tokens-database.txt fields more robustly, and simplify parsi…
muz Dec 26, 2025
9b4b6b3
Remove deprecated Image Filename column from tokens-database.txt
muz Dec 27, 2025
2f66f96
Re-add guard if a line item isn't parsed as expected in TokenRepository
muz Jan 25, 2026
349a461
Audit and ensure all Tokens in token db point to existing Java classes
muz Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 23 additions & 28 deletions Mage/src/main/java/mage/cards/repository/TokenRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,47 +129,46 @@ private static ArrayList<TokenInfo> loadMtgTokens() throws RuntimeException {
List<String> params = Arrays.stream(line.split("\\|", -1))
.map(String::trim)
.collect(Collectors.toList());
if (params.size() < 5) {
if (params.size() != 6) { // Schema specifies 4 columns. Split provides 2 extra values from trailing and leading |
errorsList.add("Tokens database: wrong params count: " + line);
continue;
}
if (!params.get(1).toLowerCase(Locale.ENGLISH).equals("generate")) {
// TODO: remove "generate" from db
errorsList.add("Tokens database: miss generate param: " + line);
continue;
}

String objectType = params.get(1);
String tokenName = params.get(2);
String tokenClassName = params.get(4); // token class name (uses for images search for render)

// image number (uses if one set contains multiple tokens with same name)
int imageNumber = 0;
if (!params.get(4).isEmpty()) {
imageNumber = Integer.parseInt(params.get(4));
if (!params.get(3).isEmpty()) {
imageNumber = Integer.parseInt(params.get(3));
}

// token class name (uses for images search for render)
String tokenClassName = "";
if (params.size() > 7 && !params.get(6).isEmpty()) {
tokenClassName = params.get(6);
if (objectType.isEmpty() || !objectType.matches("(?:DUNGEON|EMBLEM|PLANE|TOK):[A-Z0-9]{3,4}")) {
errorsList.add("Tokens database: invalid object type declaration: " + line);
continue;
}

if (tokenName.isEmpty()) {
errorsList.add("Tokens database: missing token name: " + line);
continue;
}

if (tokenClassName.isEmpty()) {
errorsList.add("Tokens database: miss class name: " + line);
continue;
}

// object type
String objectType = params.get(2);
String tokenName = params.get(3);
String setCode = "";
String[] typeAndSet = objectType.split(":");

TokenType tokenType = null;
String setCode = typeAndSet[1];

// type - token
if (objectType.startsWith("TOK:")) {
setCode = objectType.substring("TOK:".length());
if (typeAndSet[0].equals("TOK")) {
tokenType = TokenType.TOKEN;
}

// type - emblem
if (objectType.startsWith("EMBLEM:")) {
setCode = objectType.substring("EMBLEM:".length());
if (typeAndSet[0].equals("EMBLEM")) {
tokenType = TokenType.EMBLEM;
if (!tokenName.startsWith("Emblem ")) {
errorsList.add("Tokens database: emblem's name must start with [Emblem ...] word: " + line);
Expand All @@ -181,9 +180,7 @@ private static ArrayList<TokenInfo> loadMtgTokens() throws RuntimeException {
}
}

// type - plane
if (objectType.startsWith("PLANE:")) {
setCode = objectType.substring("PLANE:".length());
if (typeAndSet[0].equals("PLANE")) {
tokenType = TokenType.PLANE;
if (!tokenName.startsWith("Plane - ")) {
errorsList.add("Tokens database: plane's name must start with [Plane - ...] word: " + line);
Expand All @@ -195,9 +192,7 @@ private static ArrayList<TokenInfo> loadMtgTokens() throws RuntimeException {
}
}

// type - dungeon
if (objectType.startsWith("DUNGEON:")) {
setCode = objectType.substring("DUNGEON:".length());
if (typeAndSet[0].equals("DUNGEON")) {
tokenType = TokenType.DUNGEON;
if (!tokenClassName.endsWith("Dungeon")) {
errorsList.add("Tokens database: dungeon's class name must ends with [...Dungeon] word: " + line);
Expand Down
Loading