Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the idea of poking at systematically finding and generating tokens as new set data is released. To enable this, some understanding of the current database was needed on my side. I then saw
// TODO: remove "generate" from dbon the codebase and some codepaths that could be tidied up a bit...This should be a functional no-op to the end user, but internally:
tokens-database.txtare as expectedI was able to confirm that the existing data in database was consistently formatted with the same number of columns;
I was also able to confirm what used to be the ImageFileName column was empty for all rows;
Confirmed that the only thing reading the tokens-database.txt and in active use right now is
TokenRepository.javawith objects it extracts being consumed downstream in the project. The generated objects from the Repository should be consistent with before.I did note that there is a Unit Test for this class, but it's currently marked as
@Ignorewith// TODO: enable test after massive token fixesso opted to not touch this right now if the test itself is not exercising value. The changes it's expecting are well beyond the scope of what this PR seeks to achieve on closing out that aforementioned TODO