[jbecke]

Stacked on #7605, which is on #7594. That PR adds the .xlsm file type and the in-sheet .xls message this PR builds on.

Macro-enabled Excel workbooks (.xlsm) now import into the sheets engine like .xlsx, with their macros removed.

Changes

• Import instead of reject. xlsx-archive.ts rejected any package containing vbaProject.bin.
  • Imports (openXlsxArchive) now accept macro parts and add import notes:
    • "VBA macros are not imported. Cells, formulas and formatting are; the macros do not run in Macro."
    • "Excel 4.0 macro sheets are not imported."
    • "Form and ActiveX controls are not imported."
  • Macro sheets were already skipped as non-grid sheets.
  • The reader never parses [Content_Types].xml, so the macro-enabled main content type needed no change.
• Exports stay macro-free. inspectXlsxArchive, the self-check on Macro's own .xlsx output, still refuses VBA projects, their signatures and macro sheets.
  • Download as Excel of an imported .xlsm writes a macro-free .xlsx.
  • An uploaded .xlsm keeps its macros in the original download.
• Type gates.
  • isUploadedWorkbook now accepts xlsm, so an uploaded .xlsm opens in the read-only workbook preview and Edit in Macro imports it into a native spreadsheet. The upload query already sends non-CSV files to the Excel worker.
  • The in-sheet Import… accepts .xlsm: extension check plus accept=".xlsm,application/vnd.ms-excel.sheet.macroEnabled.12".
  • importExcel accepts .xlsx/.xlsm.
• Docs. The agent guide describes .xlsm imports.

Testing

• xlsm-import.test.ts (7 tests):
  • Two Excel-written .xlsm files with real VBA projects from the Apache POI test data (Apache-2.0, provenance in xlsx-fixtures/README.md). One is simple; the other has comments, embedded Word/PowerPoint objects and Cyrillic sheet names. Both import with the VBA note and export without vbaProject.
  • A Macro-written workbook repackaged as .xlsm, with the macro-enabled content type, VBA project, signature and relationship, keeps its formulas, styles and notes.
  • Macro sheets and ActiveX/form controls each get their own note.
  • Native Loro save/reopen recalculates (SUM = 6,000).
  • The export opens in ExcelJS with formulas and no macro content type.
  • The export self-check still refuses macros.
• Updated tests: xlsx-codec.test.ts (macros now rejected only on export), csv-file.test.ts and create-workbook-actions.test.ts (.xlsm previews with its notes; .xltm/.xls still rejected), and uploaded-workbook.test.ts (.xlsm uploads use the Excel worker).
• Browser (Playwright, real Chromium with the real import/calc workers):
  • New: import poi-simple-macro.xlsm through the file picker, see the VBA note, replace the workbook, download, and confirm no VBA parts.
  • New: an .xls shows the upload hint.
  • The full spreadsheet browser suite: 48 of 49 pass. The one failure is the collaboration test, which needs a sync-service build (services/sync-service/build/worker/shim.mjs) that doesn't exist in this environment and doesn't touch import.
• All block-spreadsheet/block-unknown vitest suites pass (724 tests), plus tsc, biome, oxlint and ast-grep.

---

Generated by Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: macro-inc/macro/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: e1d3aaae-e2ee-4966-9f43-cb0eadbe9884

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Preview: https://claude-fervent-mccarthy-h6zlp1-wxux8h.preview.macro.com/app (d33a0d9)