Repository navigation
fix [properties-be] - bunch of fixes - #506
Merged
danielkweon merged 7 commits intoDec 9, 2025
Merged
Conversation
danielkweon
commented
Dec 8, 2025
danielkweon
commented
Contributor
- Metadata properties now include specific_entity_type (Owner → User, Project → Project)
- Properties removable except required Task properties (10 built-in Task properties protected)
- Task entity type enabled for properties API with document-based permissions
- Owner metadata now includes specific_entity_type: USER - Project metadata now includes specific_entity_type: PROJECT - String/date/null properties pass None for specific_entity_type
…roperties - Add entity_type parameter to support Task and other entity types - Replace hardcoded EntityType::Document with passed entity_type
… Task properties - Add required_property_ids_for_entity() to SystemPropertyKey for extensible required property checking - Add is_required_for_entity() to check if property is required for an entity type - Update delete_entity_property to block removal of required properties (returns 403) - Add EntityPropertyReference type for property lookups - Add lookup_entity_property() to fetch property info for deletion validation - Task properties (Assignees, Status, Priority, etc.) are protected from removal
- Task permissions use document permission check (Task entity_id = Document ID) - Task fetches document metadata properties
…operty - Restore specific_entity_type parameter to create_metadata_property_null - Project property with null value now correctly specifies EntityType::Project
synoet
approved these changes
Dec 9, 2025
danielkweon
deleted the
daniel/m-5345--fix-properties-backend-some-fixes
branch
December 9, 2025 13:14
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.